Conversation
As printing too much might lead to xruns, ratios can be printed on level 2 more safely.
The idea is to increase the loop filter bandwidth to adapt faster to possible changes in the ratio. No reset of the resampler is needed with this.
The idea is having a state to do exactly the same as with the tune state with the addition of audio processing. This might create audio artifacts, specially when the xrun comes with big fluctuations in time measurements, but avoids a complete resetting of the resampler, which skips the audio processing for as long as 7 s.
It is possible to use 6 blocks by adding a delay after the control transfer. Without this, devices crash occasionally.
There is a scenario in which the ratios are outside reasonable values and maximum and minimum values are used. In this cases, retuning the resampler will ensure the lowest latencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retuning implementation processes the audio instead of resetting the resampler, which was causing a dropout of the audio for about 7 s.
Additionally, retuning is also run when out-of-range resampling ratios are detected, which was shutting down the whole device.
See #90 for more details.