Add option to set path to custom tika config file #1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to set path to custom tika config file
Owner
|
@iadcode thanks a lot! it looks very good. do you think you could add:
? thanks again! |
Contributor
Author
|
Will do, thank you! |
Add Tika Config Path Tests and Documentation
Contributor
Author
dadoonet
requested changes
Feb 21, 2022
Owner
dadoonet
left a comment
dadoonet
left a comment
There was a problem hiding this comment.
Fantastic!
Thanks a lot for your PR. I did a first review and left some comments.
Please let me know if it's unclear.
...o/elasticsearch/crawler/fs/test/integration/elasticsearch/FsCrawlerTestTikaConfigPathIT.java
Outdated
Show resolved
Hide resolved
...o/elasticsearch/crawler/fs/test/integration/elasticsearch/FsCrawlerTestTikaConfigPathIT.java
Outdated
Show resolved
Hide resolved
...o/elasticsearch/crawler/fs/test/integration/elasticsearch/FsCrawlerTestTikaConfigPathIT.java
Outdated
Show resolved
Hide resolved
tika/src/test/java/fr/pilato/elasticsearch/crawler/fs/tika/TikaDocParserTest.java
Outdated
Show resolved
Hide resolved
tika/src/test/java/fr/pilato/elasticsearch/crawler/fs/tika/TikaDocParserTest.java
Outdated
Show resolved
Hide resolved
tika/src/test/java/fr/pilato/elasticsearch/crawler/fs/tika/TikaDocParserTest.java
Outdated
Show resolved
Hide resolved
...o/elasticsearch/crawler/fs/test/integration/elasticsearch/FsCrawlerTestTikaConfigPathIT.java
Outdated
Show resolved
Hide resolved
...o/elasticsearch/crawler/fs/test/integration/elasticsearch/FsCrawlerTestTikaConfigPathIT.java
Outdated
Show resolved
Hide resolved
- Changed link to dynamic for Tika Configuration apache documentation - Moved tika configuration file(s) - Added early fail for tika config file not found - Updated exception handling
Review Changes
Contributor
Author
|
Thank you David, those notes were all clear and very helpful. I'm sure I've missed some things though so please let me know if anything else needs an update! |
dadoonet
approved these changes
Mar 16, 2022
Owner
dadoonet
left a comment
dadoonet
left a comment
There was a problem hiding this comment.
It looks good to me. Could you solve the remaining conflict with the master branch?
Owner
|
Thanks a lot @iadcode ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path to xml tika config file can be added to _settings.yaml. If path is included and file exists, custom tika parser is used.
I looked at #498, but it's for a previous version of fscrawler and I didn't fully understand the design. I hope this is ok as a new pull request.
Thanks!