Fix: Replace AsyncWorker with ThreadSafeFunction to prevent crashes#1
Open
brandonkboswell wants to merge 1 commit intodacay:masterfrom
Open
Fix: Replace AsyncWorker with ThreadSafeFunction to prevent crashes#1brandonkboswell wants to merge 1 commit intodacay:masterfrom
brandonkboswell wants to merge 1 commit intodacay:masterfrom
Conversation
- Replaced CalendarAccessWorker, RemindersAccessWorker, and RemindersFetchWorker with thread-safe context structs - Use ThreadSafeFunction instead of AsyncWorker for cross-thread callbacks - Capture shared_ptr by value in lambdas to ensure promise lifetime - Fixes segmentation fault when macOS permission dialog callback fires This fixes crash at memory address 0x260 when users grant calendar permissions.
Author
|
@dacay let me start by saying I'm not an Objective-C coder or a Swift coder of any kind. I found that EventKit-node was crashing after accepting permissions when I went to use it. I had Claude code fix that issue, and the code that's in this fork seems to continue to maintain all the functionality that existed in your version, but doesn't crash after receiving proper permissions on macOS 26.2 Tahoe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes crash at memory address 0x260 when users grant calendar permissions.