Open
Conversation
✅ Deploy Preview for staging-dacade ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 2 commits
May 22, 2023 10:06
musayann
reviewed
May 23, 2023
Contributor
musayann
left a comment
musayann
left a comment
There was a problem hiding this comment.
The folder structure of this component doesn't make sense. I would rename it to a different name. I'm not sure why the component is named Challenge and it's within the challenge folder
musayann
requested changes
May 26, 2023
| @@ -0,0 +1,52 @@ | |||
| <template> | |||
Contributor
There was a problem hiding this comment.
I would move this component inside components/cards/challenge and name it something like Teaser or Overview.
| <script> | ||
| import Coin from '@/components/ui/Coin' | ||
| export default { | ||
| name: 'ChallengeCourseCard', |
Contributor
There was a problem hiding this comment.
here the name would then be ChallengeTeaserCard
musayann
requested changes
May 26, 2023
| > | ||
| <div class="text-gray-900 text-lg leading-normal capitalize"> | ||
| <span class="text-default font-medium" | ||
| >ready ready to complete the challenge?</span |
Contributor
There was a problem hiding this comment.
Do we need this component?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.