Core 248 profile settings page#251
Conversation
gabrielaacha
commented
Mar 7, 2023
gabrielaacha
commented
- set up page and relevant components
-
- style the elements in the components (still hard coded)
✅ Deploy Preview for staging-dacade ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
musayann
left a comment
musayann
left a comment
There was a problem hiding this comment.
Please review my comments below
…/dacade-webapp into core-248-profile-settings-page
musayann
left a comment
musayann
left a comment
There was a problem hiding this comment.
We still have conflicts on this branch as well
| }, | ||
| } | ||
| </script> | ||
|
|
There was a problem hiding this comment.
I don't think this is used anywhere
There was a problem hiding this comment.
you mean the component? It is used in components/list/Bounty
| {{ $t('profile.header.disconnect') }} | ||
| </Button> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
I would cleanup this component and fix the indentation issues
There was a problem hiding this comment.
not sure what exactly needs to be cleaned here
| <div class="py-5.5"> | ||
| <div class="flex items-center"> | ||
| <h6 | ||
| class="text-xs leading-relaxed font-semibold pb-5 text-gray-500 uppercase" |
There was a problem hiding this comment.
I would fix the indentation in this component as well
| <div class="pr-2 text-sm flex items-center"><DiscordIcon /></div> | ||
| <div class="text-sm self-center">{{ $t('profile.edit.discord') }}</div> | ||
| </div> | ||
| <div class="flex justify-end text-primary text-sm"> |
There was a problem hiding this comment.
We should link this document with the actual discord connect status. in the profile header you can find the related attributes that can be used to show the right state
| class="bg-transparent text-blue-400 self-start px-2.5 py-2.5 absolute bottom-6" | ||
| @click="close" | ||
| > | ||
| <!-- <Crossmark class="text-xl text-gray-600 w-6" /> --> |
There was a problem hiding this comment.
We can remove this unused component here (in the comments)
musayann
left a comment
musayann
left a comment
There was a problem hiding this comment.
We still have conflicts on this branch as well
musayann
left a comment
musayann
left a comment
There was a problem hiding this comment.
We still have conflicts on this branch as well
3 participants
