custom formatters for partitioning #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Things I don't like:
First could be solved by extracting the parse logic from e.g. Iso8601DateFormatter into some mthod with a considerSpecial flag. This would come at the cost of the code more difficult to read. E.g. we might need an extra abstract base class.
Second can only be solved if we decide we don't need to support legacy formats, but this would be a breaking change with the previous code.