Device: Send extended init packet to all AirPods models#517
Merged
Conversation
Older devices silently ignore the 0x4D packet, so there is no need to gate it per model. Sending it unconditionally prevents silent feature degradation when new H2+ models are added without the flag. Remove needsInitExt from PodModel.Features.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The extended init packet (0x4D) is now sent to all connected AirPods during the AAP handshake, instead of only to specific newer models. Older devices silently ignore the packet, so this is safe. New H2+ models will automatically get full feature support (Adaptive Transparency, Conversational Awareness during playback) without needing a per-model flag.
Technical Context
needsInitExtboolean inPodModel.Featuresgated whether the 0x4D packet was sent during connection setup. Only 5 H2-chip models had it set totrue.needsInitExtfromFeaturesentirely and changedencodeInitExt()from nullable to non-null.