Device: Log raw bytes of outgoing AAP commands for debugging#509
Merged
Conversation
Mirrors the existing incoming MSG log so a full transcript can verify round-trips for settings the device doesn't echo back.
d4rken
added
the
coms/AAP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
No user-facing behavior change. Outgoing AAP commands (settings writes, ANC mode changes, renames, etc.) now log their raw hex bytes at VERBOSE level.
Technical Context
sendRawlogged"Sent command: $command (N bytes)"at DEBUG, so bug-report logs showed the intent but not the actual wire bytes. For settings like PressSpeed where the device doesn't echo the change back, there was no way to verify from a log that the encoder produced what we expected.SEND cmd=… len=… raw=…line mirrors the existing incomingMSG cmd=… raw=…format at the same level, so a VERBOSE transcript now contains complete send/receive pairs.