Fix: Fix crash when monitor service fails to start in time#504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fixed a crash that could occur when the system kills the monitor service before it finishes starting up. This typically happens on cold starts triggered by Bluetooth events when the device is under load.
Technical Context
ForegroundServiceDidNotStartInTimeExceptionwhenstartForeground()isn't called within ~5 seconds ofstartForegroundService(). The existing earlypromoteToForeground()call before Hilt DI mitigates most cases, but the system can still throw the exception on the main thread beforeMonitorService.onCreate()even runs — no in-service fix can prevent that.Bugs.report(), and revives the main Looper withLooper.loop()so the app continues functioning instead of crashing. A one-shot guard prevents recursive Looper nesting if the exception fires twice. This matches the approach from Revive main Looper after suppressing foreground service timing exception bluemusic#207.super.onCreate()(Hilt DI) without a try-catch, so a DI failure there would crash unhandled. Now wrapped in the same try-catch as the normal path.injectionCompleteflag soonDestroy()doesn't access@Inject lateinit varfields when DI never completed, preventingUninitializedPropertyAccessException.