Extract monitoring orchestration from MonitorService#209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VolumeEventDispatcher— moves volume event priority dispatch out of MonitorService into a standalone, testable class. Replaces AndroidSparseArraywithgroupBy/toSortedMapand fixesCancellationExceptionswallowing.MonitorOrchestrator— moves flow wiring and shutdown heuristics out of MonitorService. Uses an internal childJobfor lifecycle control instead of cancelling the caller's scope. Captures the initial device snapshot once to avoid a race condition.MonitorServicedown to a lifecycle shell (173 lines, 6 injections) — foreground promotion, session tracking, teardown, and notification updates via callback.Test plan
VolumeEventDispatcherTest— 5 tests: priority ordering, parallel execution, error isolation,CancellationExceptionrethrow, empty setMonitorOrchestratorTest— 9 tests: bootstrap sequence, 3 shutdown heuristic branches, device list updates, 3 failure isolation lanesassembleFossDebugcompiles