Rewrite connection handling with per-device volume ownership#206
Merged
Rewrite connection handling with per-device volume ownership#206
Conversation
Make VolumeDisconnectModule non-cancellable so disconnect saves survive fast reconnects. Return ConnectResult from onDeviceConnected to enable EventDispatcher to cancel displaced owner ramps when ownership transfers. Add resetBlocking for service teardown. Document chaotic reconnect volume churn as known limitation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a central
AudioStreamOwnerRegistrythat tracks which device group owns shared audio streams, replacing the previous broadcast-to-all approach. This ensures volumes are only applied to the correct device when multiple Bluetooth devices are connected simultaneously.AudioStreamOwnerRegistrywith device grouping (Samsung Buds L+R pair within 10s window), ownership resolution (latest connection wins, fresh > bootstrap, real > speaker fallback), and stale disconnect protectionEventDispatcherwith fast acceptance lane (ownership updated synchronously before async module launch), per-address job supersession, and displaced owner cancellation when ownership transfersVolumeDisconnectModulenon-cancellable so disconnect volume saves survive fast reconnectsVolumeUpdateModule,VolumeLockModule,VolumeRateLimiterModule, andRingerModeTransitionHandlerTesting
AudioStreamOwnerRegistryTest,EventDispatcherTest,BaseVolumeModuleTest,VolumeDisconnectModuleTest,VolumeLockModuleTest,VolumeUpdateModuleTest,VolumeRateLimiterModuleTest, and others