fix: Make lone wolf perk into toggle

[slevenstein]

Making Lone Wolf into a toggle since it seemingly only has 2 states when foundry shows 3 (None, Base, and Alone).

If it does in fact have 3 states and the perk description is wrong, someone please correct me.

[slevenstein]

not sure if this is needed as this was automatically changed

[JayAndromeda]

lol yes :) please always include this file with your prs.

[JayAndromeda]

I added some comments as to what I think might be the best of both worlds. if you agree just add em to your branch and ill merge it in. my issue i have with a toggle is that usually the 'off' state means no effect in our current philosophy but i do agree with you that it is a two state perk. adding as an options_raw makes it more clear in my opinion to the user that there is a base effect.

[JayAndromeda]

I agree that it is a two state perk and it did always bother me about the 'none' option but seeing this pr reminded me of the options_raw perk option as well. It's basically the same as options but doesnt include a none by default so _input.value = 0 is whatever the first value you give is. A toggle in our current UX usually means no effect so thats why i think this option fits a little better than a toggle.

Perks::LoneWolf => Some(PerkOptionData::options_raw(["Base", "Alone"].to_vec())),

[JayAndromeda]

we've been adding in clamped values simply as a protection from editing the value in the url or otherwise. it would look like this as an end result.

add_sbr(
        Perks::LoneWolf,
        Box::new(|_input: ModifierResponseInput| -> HashMap<u32, i32> {
            let mut stats = HashMap::new();
            let val = clamp(_input.value, 0, 1);
            let enhance_buff = if _input.is_enhanced { 1 } else { 0 };
            stats.insert(
                StatHashes::AIRBORNE.into(),
                (15 + 2 * enhance_buff) * (val + 1) as i32,
            );
            stats.insert(
                StatHashes::AIM_ASSIST.into(),
                (5 + enhance_buff) * (val + 1)  as i32,
            );
            stats
        }),
    );
    add_hmr(
        Perks::LoneWolf,
        Box::new(
            |_input: ModifierResponseInput| -> HandlingModifierResponse {
                let val = clamp(_input.value, 0, 1);
                let enhance_buff = if _input.is_enhanced { 0.05 } else { 0.0 };
                HandlingModifierResponse {
                    ads_scale: 0.9 - (0.1 * val as f64) - enhance_buff,
                    ..Default::default()
                }
            },
        ),
    );

[JayAndromeda]

lol yes :) please always include this file with your prs.