chore: Add helpers for standard damage modifiers + surge damage modifiers #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlaminSarge
changed the title
FlaminSarge
force-pushed
the
dmghelpers
branch
2 times, most recently
from
dff656b to
1a8f38a
Compare
…iers basic_dmg_mod buffs impact, explosive, and melee surge_mod buffs just impact and explosive
BarmonHammer
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basic_dmg_mod buffs impact, explosive, and melee (melee is pending the Glaive impl, which will add the melee_dmg_scale field)
surge_mod buffs just impact and explosive
As a general rule of thumb, empower buffs and weaken effects use basic_dmg_mod and surge buffs use surge_mod (ofc).
I pulled this out of #105 to clean that PR up a bit.