Open
Conversation
- rename 'rangePositionToPixelPosition' and 'pixelPositionToRangePosition' functions to 'pixelToValue' and 'valueToPixel' to more accurately describe the functions
- also rework number renderer to round values to avoid displaying large decimals
- add margin right and update bounds to the drag area - user can drag slightly over top margin which will allow them to increase the y value of the handle and increase the range of the chart
- reduce fonts/spacing of number mapper handle info boxes - dragged handle will have highest z index
- vpType color means create a color mapping - vpType number means create a number mapping with defaults 1 to 100 - vpType that is for opacity means create a number mapping from 0 to 1
…maller values - last dragged handle will be rendered with a higher z index - render range as well as domain (TODO make range editable)
- update handles that may be outside of the domain when the domain is directly changed
- remove 'pixelPosition' from handle interface - use visx scale api instesad of d3 for now - improve variable names re. magic numbers - handle positions are derived from values instead of using 'pixelPosition' state on the handle
- create color gradient component - reuse common handle function code in the color mapper ui - general function and visuals are consistent between color mapper and number mapper now
Update timing problems have been resolved
use type enums instead of hard coded strings
- remove code that is never called - export all visual style models to the top level of the visual style module - make the visual style fn impl export consistent with other model exports
- rename visualStyle-util.ts to compute-view-util.ts as all functions in the file relate to computing views - remove more unused code
…ollow this convention.
Vs model cleanup merged to develop
…ethod before calling it
…storing it in the column definition
…data sets after login.
…value Remove the concept of 'defaultValue' for columns
Keycloak login
- compute metadata aspect from aspects array - better names for the various visual property conversion functions
- export network attributes by parsing the ndex network summary model - move mapping function converters to the cxVisualPropertyConverter module
![chatcody[bot]](https://avatars.githubusercontent.com/in/280407?s=60&v=4){kind=small}
| <!-- this div is needed by the glide-data-grid to render the table browser--> | ||
| <div id="portal" style="position: fixed; left: 0; top: 0; z-index: 9999" /> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
@d2fong, the changes in the pull request look good. However, I noticed a typo in the comment. "browser" is misspelled as "browsser". Please correct it to ensure clarity for future developers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.