Reverted OnIMEUpdate to use TextLine.SetText#78
Open
ErLullo wants to merge 1 commit intod1str4ught:mainfrom
Open
Reverted OnIMEUpdate to use TextLine.SetText#78ErLullo wants to merge 1 commit intod1str4ught:mainfrom
ErLullo wants to merge 1 commit intod1str4ught:mainfrom
Conversation
It seems to fix the cursor issue on textboxes
Contributor
|
Reverting this will stop noticeBoard from working. Good luck you all! |
Contributor
|
Found the issue and fixed it. The revert is valid. The fix will be applied in the next PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems to fix the cursor issue on textboxes.
fix: avoid IME ↔ EditLine loop
Previously,
OnIMEUpdateusedEditLine.SetText, which, when the control has focus, also callsime.SetText. SinceOnIMEUpdateis already invoked by the IME after its internal buffer is updated, sending the same text back into the IME creates an unnecessary and potentially unstable synchronization loop. We now useTextLine.SetText(self, ime.GetText())to update only the UI without touching the IME’s internal state.@rtw1x1 please verify it because it is a revert from your merge