fix(virtio): sync descriptor indices to resolve stressfs read hang#40
Open
ping-long-github wants to merge 1 commit intod0iasm:mainfrom
Open
fix(virtio): sync descriptor indices to resolve stressfs read hang#40ping-long-github wants to merge 1 commit intod0iasm:mainfrom
ping-long-github wants to merge 1 commit intod0iasm:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixed a synchronization issue in virtio_blk.rs that caused the xv6 stressfs test to hang indefinitely during the read phase.
Changes:
Switched from using the guest's avail.idx to the device's internal cpu.bus.virtio.id to correctly fetch the head index for the next available descriptor.
Moved interrupt_status |= 0x1 to the end of disk_access to ensure the used ring is fully updated before the xv6 kernel receives the completion interrupt.
Testing:
Successfully ran xv6 stressfs and usertests without hanging.