Update item_special.js so that Valor set is correct#482
Open
Tungul wants to merge 1 commit intod07RiV:masterfrom
Open
Update item_special.js so that Valor set is correct#482Tungul wants to merge 1 commit intod07RiV:masterfrom
Tungul wants to merge 1 commit intod07RiV:masterfrom
Conversation
Resolves issue d07RiV#476, issue d07RiV#450, issue d07RiV#425, and fully resolves issue d07RiV#420. Ran into this issue today - just a small typo in the item data listing.
Tungul
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #476, issue #450, issue #425, and fully resolves issue #420.
Ran into this issue today - just a small typo in the item data listing. Apologies, I didn't configure an entire dev environment to actually test this fix, but hopefully it's simple enough the correctness is evident?
I saw in the fix for #420 that there were a number of other changes to various other files - I think you're changing timestamps, but I wasn't clear what the intent was of those changes, so I couldn't match them here.
Thanks for your time.