Allow injection of a logger into tenantmiddleware#29
Open
tlanfer wants to merge 4 commits intod-velop:mainfrom
tlanfer:master
Open
Allow injection of a logger into tenantmiddleware#29tlanfer wants to merge 4 commits intod-velop:mainfrom tlanfer:master
tlanfer wants to merge 4 commits intod-velop:mainfrom
tlanfer:master
Conversation
mtestrot
reviewed
Dec 3, 2020
| // If the headers are not present the given defaultSystemBaseUri and tenant "0" are used. | ||
| // The signatureSecretKey is specific for each App and is provided by the registration process for d.velop cloud. | ||
| func AddToCtx(defaultSystemBaseUri string, signatureSecretKey []byte) func(http.Handler) http.Handler { | ||
| func AddToCtx(defaultSystemBaseUri string, signatureSecretKey []byte, logger func(ctx context.Context, message string)) func(http.Handler) http.Handler { |
Member
There was a problem hiding this comment.
Please use logError instead of logger for the name of the log func param to use a naming similar to the idp middleware.
| if systemBaseUri != "" || tenantId != "" { | ||
| if signatureSecretKey == nil { | ||
| log.Printf("error validating signature for headers '%v' and '%v' because secret signature key has not been configured", systemBaseUriHeader, tenantIdHeader) | ||
| logger(req.Context(), fmt.Sprintf("validating signature for headers '%v' and '%v' because secret signature key has not been configured", systemBaseUriHeader, tenantIdHeader)) |
Member
There was a problem hiding this comment.
Consider using the local ctx var because it is shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28
Add an additional parameter to the signature of
AddToCtx, allowing the caller to inject a logger method, similar to the idp middleware.