Skip to content

Fix issue where filepicker and directorypicker buttons were not working on macos #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zacharybutler wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue where filepicker and directorypicker buttons were not working on macos #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 34 additions & 30 deletions criticus/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,38 +55,42 @@ def startup(self):

async def on_running(self):
while True:
task: dict[str, str] | None = await self.webview.evaluate_javascript(
"getTask()"
)
if not task:
await asyncio.sleep(0.5)
continue
if task.get("name") == "pick_directory":
directory = await self.pick_directory()
if directory:
directory = Path(directory).as_posix()
self.webview.evaluate_javascript(
f"setInputValue('{directory}', '{task.get('target')}')"
)
elif task.get("name") == "pick_file":
file = await self.pick_file(task.get("ext", "txt"))
if file:
file = Path(file).as_posix()
self.webview.evaluate_javascript(
f"setInputValue('{file}', '{task.get('target')}')"
)
elif task.get("name") == "new_file":
file = await self.new_file(task.get("ext", "txt"))
if file:
file = Path(file).as_posix()
try:
task: dict[str, str] | None = await self.webview.evaluate_javascript(
"getTask()"
)
if not task or not isinstance(task, dict) or "name" not in task:
await asyncio.sleep(0.5)
continue
if task.get("name") == "pick_directory":
directory = await self.pick_directory()
if directory:
directory = Path(directory).as_posix()
self.webview.evaluate_javascript(
f"setInputValue('{directory}', '{task.get('target')}')"
)
elif task.get("name") == "pick_file":
file = await self.pick_file(task.get("ext", "txt"))
if file:
file = Path(file).as_posix()
self.webview.evaluate_javascript(
f"setInputValue('{file}', '{task.get('target')}')"
)
elif task.get("name") == "new_file":
file = await self.new_file(task.get("ext", "txt"))
if file:
file = Path(file).as_posix()
self.webview.evaluate_javascript(
f"setInputValue('{file}', '{task.get('target')}')"
)
elif task.get("name") == "normalize":
text = normalize_greek(task.get("value"))
self.webview.evaluate_javascript(
f"setInputValue('{file}', '{task.get('target')}')"
f"setInputValue('{text}', '{task.get('target')}')"
)
elif task.get("name") == "normalize":
text = normalize_greek(task.get("value"))
self.webview.evaluate_javascript(
f"setInputValue('{text}', '{task.get('target')}')"
)
except Exception as e:
print(f"Error in on_running: {e}")
await asyncio.sleep(1)

async def pick_directory(self):
dialog = toga.SelectFolderDialog(
Expand Down