Fix ineffective conditional in search view (#136)#137
Open
qzMalekuz wants to merge 1 commit intocytoscape:masterfrom
Open
Fix ineffective conditional in search view (#136)#137qzMalekuz wants to merge 1 commit intocytoscape:masterfrom
qzMalekuz wants to merge 1 commit intocytoscape:masterfrom
Conversation
Author
|
Hi @coleslaw481 , I’ve implemented a fix for this issue and opened a PR. Summary of fix
Please let me know if you’d like any changes or additional tests. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Problem
The condition
if None in c['results']incorrectly checks for a keyNone, which always evaluates to False.Fix
Updated the condition to check whether the primary search results are non-empty.
Result
Primary search results are now correctly prioritized over fallback results.