Skip to content

Fix ineffective conditional in search view (#136)#137

Open
qzMalekuz wants to merge 1 commit intocytoscape:masterfrom
qzMalekuz:fix/search-logic-136
Open

Fix ineffective conditional in search view (#136)#137
qzMalekuz wants to merge 1 commit intocytoscape:masterfrom
qzMalekuz:fix/search-logic-136

Conversation

@qzMalekuz
Copy link
Copy Markdown

Fixes #136

Problem

The condition if None in c['results'] incorrectly checks for a key None, which always evaluates to False.

Fix

Updated the condition to check whether the primary search results are non-empty.

Result

Primary search results are now correctly prioritized over fallback results.

@qzMalekuz
Copy link
Copy Markdown
Author

Hi @coleslaw481 ,

I’ve implemented a fix for this issue and opened a PR.

Summary of fix

  • Replaced the ineffective condition if None in c['results']
  • Now correctly checks whether primary search results are non-empty
  • Ensures primary results are prioritized over fallback search

Please let me know if you’d like any changes or additional tests.

Thanks
zafar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ineffective conditional and logic error in "search()" view.

1 participant