changed searching of local db to ignore (some) special characters#56
Open
McNetic wants to merge 1 commit intocytec:masterfrom
Open
changed searching of local db to ignore (some) special characters#56McNetic wants to merge 1 commit intocytec:masterfrom
McNetic wants to merge 1 commit intocytec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was especially a problem for german umlauts, when the database contained names with umlauts (like "Wickie und die starken Männer", while the release replaced the umlaut with two characters ("Wickie und die starken Maenner"). SQLite "LIKE" comparison does not treat that as alike (and it also fails to treat different case on other special characters correctly).
I'm not sure this is the best way to handle the problem, and I only added some special characters so far (while others may be advisable, too), but it works.