Fix crashing epub generation when image has no src#86
Open
DanielApt wants to merge 1 commit intocyrilis:masterfrom
Open
Fix crashing epub generation when image has no src#86DanielApt wants to merge 1 commit intocyrilis:masterfrom
DanielApt wants to merge 1 commit intocyrilis:masterfrom
Conversation
|
@cyrilis 👋 are you around to check out these PRs? Maybe time to pass the torch to a different maintainer if you don't want to deal with this anymore? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an image has no
srcattribute, epub generation fails.Epub generation fails, because it always assumes that
urlis a string, this is not the case.Specifically, code breaks on this line.
To prevent this from happening, this pull request checks if
urlexists before proceeding with setting ids and extensions.This is a simplified version of #63, without any conflicts.