Add: timeout and retry for image download.#72
Open
gonejack wants to merge 3 commits intocyrilis:masterfrom
Open
Add: timeout and retry for image download.#72gonejack wants to merge 3 commits intocyrilis:masterfrom
gonejack wants to merge 3 commits intocyrilis:masterfrom
Conversation
Signed-off-by: gonejack <igonejack@gmail.com>
Signed-off-by: gonejack <igonejack@gmail.com>
Author
|
SuperAgent's implementation is not good or misleading after browsing their code and discovery their code would not work as people's expectation, I would rewrite related code later. |
Signed-off-by: gonejack <igonejack@gmail.com>
|
+1 This is a huge improvement and keeps the experience smooth saving the manual work of pre-downloading images and changing |
gonejack
force-pushed
the
master
branch
3 times, most recently
from
906b40b to
d3975f7
Compare
Daylon
pushed a commit
to Daylon/epub-gen
that referenced
this pull request
Sep 29, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: gonejack igonejack@gmail.com
Hi, @cyrilis
I add default timeout and retry setting for image downloads for epub-gen, with SuperAgent's built-in feature.
About the tempDir, just to avoid epub-gen creates files under people's node_modules, I think it's a mistake so I change it.
New to coffee script but do run the test.