Implement code changes to enhance functionality and improve performance#7
Open
Implement code changes to enhance functionality and improve performance#7
Conversation
…into cnd-handson
There was a problem hiding this comment.
Pull Request Overview
This PR enhances documentation for deploying the Argo Rollouts demo, corrects gateway port instructions, and tidies up README links. It also adds an Istio architecture diagram (with an unintentional backup file).
- Added detailed Argo Rollouts demo instructions in
handson/README.md - Updated port number from 8080 to 80 in
bookinfo/README.md - Fixed link formatting in root
README.md - Introduced
images/istio.drawiodiagram and an accidental backup file
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| images/istio.drawio | New draw.io diagram of Istio architecture |
| images/.$istio.drawio.bkp | Backup of draw.io file, likely accidental |
| handson/README.md | Added step-by-step Argo Rollouts demo deployment guide |
| bookinfo/README.md | Changed gateway port number from 8080 to 80 |
| README.md | Fixed formatting of CloudNative Days link |
Comments suppressed due to low confidence (3)
handson/README.md:1
- The header contains extraneous text (
Add commentMore actions). It should be cleaned up to read simply# Argo Rollouts Demo Applicationfor clarity.
# Argo Rollouts Demo ApplicationAdd commentMore actions
handson/README.md:30
- The gcloud command uses
$PROJECT_IDand$DNS_SUFFIXbut these variables are not defined in this guide. Consider adding a prerequisite step to set or export these environment variables.
gcloud dns --project=$PROJECT_ID record-sets create "csm.${DNS_SUFFIX}." \
images/.$istio.drawio.bkp:1
- This appears to be a backup file for the draw.io diagram. Consider removing it or excluding it via .gitignore to avoid cluttering the repo.
<mxfile host="Electron" agent="Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) draw.io/26.0.16 Chrome/132.0.6834.196 Electron/34.2.0 Safari/537.36" version="26.0.16">
- Added new image files: csm-cloudapi.png and csm-istio.png. - Updated the istio.drawio diagram with layout adjustments and removed unnecessary elements for clarity. - Adjusted positions and sizes of various components in the diagram to improve visual representation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to documentation and deployment instructions for the
handsonnamespace, as well as minor corrections to existing content. The most important changes are grouped below:Documentation Updates:
handsonnamespace, deploy resources, retrieve service details, and configure DNS records. Cleanup instructions were also included. (handson/README.md)Minor Fixes:
README.mdfile for the "CloudNative Days hans on | Istio" link. (README.md)bookinfo-gateway.yamlinstructions to reflect a change in thespec.servers.port.numberfield from8080to80. (bookinfo/README.md)