Ignore after and first attributes with default values#64
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #64 +/- ##
============================================
+ Coverage 95.26% 95.29% +0.02%
- Complexity 244 248 +4
============================================
Files 30 30
Lines 782 786 +4
============================================
+ Hits 745 749 +4
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roxblnfk
approved these changes
Jul 13, 2025
after and first attributes with default values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the pull request cycle/database#226 has been merged, it might be a good idea to ignore the
firstandafterattributes when equaling the default values? So migrations are not declaring them for every column when not needed.🔍 What was changed
firstandafterattributes when equaling the default values.Renderer::columnOptionsmethod.🤔 Why?
When thinking about how column positioning would be used in migrations, I'm of the opinion they would be defined manually. As in I can't imagine defining this for an entity, instead I'd likely generate a migration, say containing an added column and then modify the options to position the new column after and existing column, to suit an order I prefer.
📝 Checklist