Conversation
…-comparison # Conflicts: # tests/Database/Functional/Driver/MySQL/Schema/BooleanColumnTest.php
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #234 +/- ##
============================================
+ Coverage 95.41% 95.42% +0.01%
- Complexity 1891 1896 +5
============================================
Files 131 131
Lines 5273 5285 +12
============================================
+ Hits 5031 5043 +12
Misses 242 242 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@puzzledpolymath WDYT about this approach? |
|
@roxblnfk While seemingly more complex, your solution is better. I wasn't aware of this and completely bypassed the comment.
I've tested locally and you're changes have the same affect. You have my approval 🥇 Looking forward to this getting resolved finally and a |
puzzledpolymath
left a comment
There was a problem hiding this comment.
Looks great, appreciate the time and effort
Continue #230
In cases where the field size is unknown but we are comparing with a bool, we adjust the field size to 1.