Skip to content

Remove check for docblock when trying to find parent entities (#54)#55

Merged
roxblnfk merged 4 commits intocycle:3.xfrom
makedo:bugfix/missed-registry-children-fix
Feb 1, 2023
Merged

Remove check for docblock when trying to find parent entities (#54)#55
roxblnfk merged 4 commits intocycle:3.xfrom
makedo:bugfix/missed-registry-children-fix

Conversation

@makedo
Copy link
Contributor

@makedo makedo commented Jun 21, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #55 (6e998d0) into 3.x (fa3263e) will increase coverage by 0.12%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.x      #55      +/-   ##
============================================
+ Coverage     90.74%   90.86%   +0.12%     
+ Complexity      253      252       -1     
============================================
  Files            32       32              
  Lines           648      646       -2     
============================================
- Hits            588      587       -1     
+ Misses           60       59       -1     
Impacted Files Coverage Δ
src/Utils/EntityUtils.php 90.47% <ø> (+3.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@roxblnfk roxblnfk linked an issue Jun 22, 2022 that may be closed by this pull request
1 task
@roxblnfk
Copy link
Member

Can you add test case?

@makedo makedo force-pushed the bugfix/missed-registry-children-fix branch from b8dfa92 to 95f190d Compare June 28, 2022 00:55
@makedo makedo force-pushed the bugfix/missed-registry-children-fix branch from 95f190d to c82adb2 Compare June 28, 2022 00:56
@makedo
Copy link
Contributor Author

makedo commented Jun 28, 2022

Can you add test case?

Added test case. Not sure if the way test implemented is fine. Thank you.

@roquie
Copy link
Contributor

roquie commented Sep 12, 2022

After this fix I got generated extra columns from child entities in parent class (JTI usage) schema declaration. Don't merge it. Need complex test and code refactoring.

@roxblnfk
Copy link
Member

roxblnfk commented Jan 21, 2023

@msmakouz may be related to #65

@msmakouz
Copy link
Member

msmakouz commented Feb 1, 2023

After this fix I got generated extra columns from child entities in parent class (JTI usage) schema declaration. Don't merge it. Need complex test and code refactoring.

Hi, this bug fixed by: #65

@msmakouz msmakouz self-requested a review February 1, 2023 16:08
@roxblnfk roxblnfk merged commit 0e0afb4 into cycle:3.x Feb 1, 2023
@roxblnfk roxblnfk added type:bug Bug and removed type:enhancement Enhancement. labels Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Child entities are not added to registry when using attributes🐛

5 participants