Stake in a box #314 #315 #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxcat
reviewed
Mar 5, 2020
it is needed when handling notifications in other contacts
s-medvedev
reviewed
Mar 11, 2020
cyber.box/src/cyber.box.cpp
Outdated
| auto box_itr = boxes_idx.find({contract, title}); | ||
| eosio::check(box_itr != boxes_idx.end(), "box does not exist"); | ||
| require_auth(box_itr->owner); | ||
| if (!box_itr->empty && release) { |
There was a problem hiding this comment.
I think contract should prohibit unpack empty box.
s-medvedev
reviewed
Mar 11, 2020
cyber.box/src/cyber.box.cpp
Outdated
| boxes_idx.erase(box_itr); | ||
| } | ||
|
|
||
| void box::unpack(name contract, name treasurer, name title) { |
There was a problem hiding this comment.
unpack and burn can take owner as argument. In this case unpack can send notification to contract instead call contract's release action. These modification enable to use release` action to self-purposes for contract.
zxcat
reviewed
Mar 11, 2020
zxcat
previously approved these changes
Mar 13, 2020
zxcat
previously approved these changes
Mar 18, 2020
zxcat
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.