Conversation
JackMeadDev
left a comment
JackMeadDev
left a comment
There was a problem hiding this comment.
Nice work, I can see your pipeline pushing your image to DockerHub, and the app running happily in Heroku. We would want to connect the pipeline up to update the Heroku image too, but given the Heroku free tier ends soon anyway I suggest we just achieve the equivalent with our Azure service in M9. A couple of optional thoughts are below, but happy for you to merge this when you're ready!
| And save the key in Github Secrets as: | ||
| HEROKU_API_KEY No newline at end of file |
There was a problem hiding this comment.
This seems to imply your pipeline can handle deploying to Heroku, but I can't see any evidence it tries to do that?
We do (did) want to do that as part of the pipeline, but since Heroku is going to lose the free tier very shortly I recommend we skip it and just set up an equivalent to Azure as part of M9
| DOCKERHUB_PASSWORD | ||
| DOCKERHUB_USERNAME | ||
|
|
||
| ## Heroku: |
There was a problem hiding this comment.
Thanks for the clear instructions!
| FROM base as production | ||
| EXPOSE 80 | ||
| CMD poetry run gunicorn "todo_app.app:create_app()" -b 0.0.0.0:80 | ||
| CMD poetry run gunicorn "todo_app.app:create_app()" -b 0.0.0.0:${PORT:-5000} |
There was a problem hiding this comment.
Minor, but here you've swapped the default port from 80 to 5000 for your prod container, which might mean old instructions (including port mappings in your docker-compose file) are no longer accurate
2 participants
Module 8 submission:
Automatic Docker Hub publish added to pipeline
Dockerfile changed so the ports work
Heroku Manual Publish worked.
https://markdossantos-module8.herokuapp.com/