Refactor, and consolidation of duplicated code in the project #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a browser-safe benchmark core and a Node-only "@treecrdt/benchmark/node" export for writeResult/repoRoot/CLI helpers. Refactor bench runners (sqlite-node/wa-sqlite/wasm) + wa-sqlite e2e bench specs to use shared timing/workload parsing, and stop tracking generated benchmarks output. Also move bench-only deps to devDependencies and tighten wa-sqlite statement iteration cleanup.
Expose "@treecrdt/sync/bench" for queued backends + in-memory connected peers, and "@treecrdt/sync/protobuf" for the v0 codec. Update sqlite-node bench-sync, wa-sqlite e2e sync bench, and sync smoke tests to use the shared helpers (with proper detach/flush).
Extend the treecrdt wa-sqlite Vite plugin to support multiple outDirs and to copy assets once per build. Use the plugin in the e2e app (including base-path build) and drop the ad-hoc postbuild copy script wiring.
- wa-sqlite opfs helpers now reuse makeDbAdapter (including iter.return cleanup) - copy-opfs-vfs.mjs and copy-ext.mjs use shared scripts/repo-root.mjs
- Expand TreecrdtAdapter with docId/opRefs/tree/meta methods - Make createTreecrdtSqliteAdapter return the full adapter (internalize sqlite helpers) - Simplify sqlite-node/wa-sqlite to create*Api only and reuse cached runner/api per db - Flesh out wasm-js adapter to satisfy full interface; drop redundant wasm module stub types - Update benches + fix playground protobuf codec import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #25 #26 (don't review until these are merged)