V0 sync protocol draft #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonov548
reviewed
Dec 23, 2025
| string doc_id = 2; | ||
|
|
||
| oneof payload { | ||
| Hello hello = 10; |
Collaborator
There was a problem hiding this comment.
as I understood to seperate oneof fields from others it has +10 to field number. Should it be also common across all schemas.
Collaborator
Author
There was a problem hiding this comment.
Good question. Feels like future top fields in the SyncMessage is more likely in the other types so I left that out there for now.
Collaborator
Author
There was a problem hiding this comment.
we can revisit this question later perhaps once we have a reference implementation going and we have gathered more potential knowledge about requirements we did not see at this stage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial draft for p2p sync behaviour. Refinements of this protocol is intended to update as we build and test