Skip to content

Conversation

@cindmichelle
Copy link
Collaborator

@cindmichelle cindmichelle commented Jan 4, 2026

part of #3018

Description

Convert em to rem unit css, affected components:

  • Bullet
  • Alert
  • BulletCursorOverlay
  • ContextBreadcrumb
  • SortPicker
  • PopupBase
  • Checkbox
  • LayoutTree

@cindmichelle cindmichelle marked this pull request as ready for review January 4, 2026 20:13
@cindmichelle cindmichelle changed the title chore: convert em to rem unit css pt 2 Convert em to rem unit css pt 2 Jan 4, 2026
@raineorshine
Copy link
Contributor

@BayuAri Could you test that there are no visual changes to the affected components? This PR is a pure refactor.

These components are visible in the editor with any thoughts:

  • Bullet
  • BulletCursorOverlay
  • LayoutTree

And the others:

  • Alert is visible after deleting a thought.
  • ContextBreadcrumb is visible in the Context View.
  • SortPicker is visible in the sort dropdown.
  • PopupBase is part of the CommandPalette.
  • Checkbox can be seen in the Settings screen.

Let me know if you can't find anything!

@raineorshine raineorshine requested a review from BayuAri January 4, 2026 20:24
Copy link
Collaborator

@BayuAri BayuAri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, the new changes are visible on the PR and this does not trigger any regression

@raineorshine raineorshine merged commit fd30cc6 into cybersemics:main Jan 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants