Add backslash path regex match as an exception to string regex #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with reverse-slashes.
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add backslash path regex match as an exception to string regex for paths with backslashes.
This change is an attempt to address the behavior reported in #5, in which a path with a backslash (
\example\path\to\thing\) resulted in the query segment not being matched to any known type. The reason for the path's exclusion is due to the regex forSTRINGintentionally excluding anything that has\present (potentially to avoid recognizing other escape/syntax a strings).This change adds an extra matcher to the
STRINGregex that attempts to account for generic alphanumeric paths with/without spacing.