Pull in upstream #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rack (#3022) * Slightly increase bicycle priority classification on "good" highway=track * Changes from review
* clean up bike speed parser * test fix and minor cleanup in priority parser * further clean up
* De-prioritize ways tagged with foot=use_sidepath * Add reason for not using REACH_DESTINATION * Update core/src/main/java/com/graphhopper/routing/util/parsers/FootPriorityParser.java Co-authored-by: Peter <graphhopper@gmx.de> --------- Co-authored-by: Peter <graphhopper@gmx.de>
* Assume Toll.HGV for all roads in Switzerland * Assume Toll.HGV for all roads in Liechtenstein
* query weighting should use the turn times (not weights) given by the actual weighting * related: da748e6
* Improvement for bicycle speed for designated path with tracktype * Update core/src/main/java/com/graphhopper/routing/util/parsers/BikeCommonAverageSpeedParser.java Co-authored-by: Peter <graphhopper@gmx.de> * Remove a new test which passes without the improvement --------- Co-authored-by: Peter <graphhopper@gmx.de>
* Provide Hong Kong and Macao definition * Add contribution * alphab. order regarding isocode not name Co-authored-by: otbutz <tbutz@optitool.de> --------- Co-authored-by: Peter <graphhopper@gmx.de> Co-authored-by: otbutz <tbutz@optitool.de>
* Limit speeds by country default speed limits * Update contributions * Mention max_speed encoded value requirement * Update description for max_speed * Mention max_speed encoded value in model files
* mtb: consider bike_network and mtb_network * minor
#3257) * * Store pillar node count as an unsigned short. This reduces geometry header size from 3 bytes to 2 bytes. * Fixed the signed overflow bug in `getPillarCount` that incorrectly limited edges to ~32k pillar nodes. * Simplify read/write logic by using `BitUtil.toShort/fromShort` instead of manual 3-byte bit shifting. * Add explicit bounds check for `MAX_PILLAR_NODES` during write. * Adjusted expectations to new Header Size (2 Bytes instead of 3 Bytes) * Add tests for pillar node limits, ensuring 2-byte header support (65k nodes) and verifying correct overflow handling and storage behavior. * Added myself to contributors * Bumped VERSION_GEOMETRY to 8 due to binary format change
* move country rules into parser * consider review comments * fix
* move country rules into parser * country rules for bike and foot
When reading key indices from storage, getShort() returns a signed short which gets sign-extended to int. For key indices >= 8192, the stored value (keyIndex << 2) exceeds 32767 and has its sign bit set. This caused the unsigned right shift to produce ~1 billion instead of the correct index, resulting in IndexOutOfBoundsException. Fix by using Short.toUnsignedInt() to properly handle the unsigned 16-bit value. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* test * fix duration * Revert "fix duration" This reverts commit 8f1b797. * just estimate the speed based on ferry length * fix test * fix comment * reduce waiting time penalty for longer ferries * account for delay directly * move speed calculation into FerrySpeedCalculator * minor comment * rename to duration:seconds (related to #2849) * minor comment * re-add todo * rename again
The property was mentioned in an error message only.
…was picked, not multiplied)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read our contributing guide and note that also your contribution falls under the Apache License 2.0 as outlined there.
Your first contribution should include a change where you add yourself to the CONTRIBUTORS.md file.