Use git submodules, and address other basic compilation issues #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use submodules so that people trying to build this don't have to experiment to figure out which version of xtl and xtensor this code supports. (hint: it's not the latest versions!)
Extensionless and callable from anywhere, by linix standards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xtlandxtensor. Never tell people to clone repos into some relative path. You are subjecting them to version hell. Git submodules exist for this very purpose, and they ensure that any given version of your code is getting the correct version of its dependencies. I had to experiment a whole bunch to figure out what versions of the libraries this code actually supports.compile.batwas generating files in the source tree, yet there was no.gitignore, so one has been added.CMakeLists.txtrequired you to runcmakein the source root directory, which is.... bananas. I fixed it so it can be used anywhere, and changed the instructions to use a dedicated binary directory, per universally-accepted best practices.compile.bat.