fix: Active cooler can only touch active cooler of the same type #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm playing nomifactory, and i've tested, it is possible to have two different active coolers touching each other without issue, both of them cool the reactor and can be filled up from outside the reactor, so please add some sort of toggle for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an additional check for active cooler that should only touch other active cooler of the same type, otherwise it's an invalid placement.
Also added a slight optimization to the accessibility check which reduces the amount of checks done and slightly increase the algorithm speed and efficiency.
I was able to compile and run locally a 10x10x10 reactor that does not have the issue anymore.
Fixes #5