Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although snaps are considered Ubuntu-centric, it's nice to have them available on other distros, for example I've been using this snap on Fedora for the last several months without issue.
Built on amd64 Ubuntu 23.04, tested on amd64 Fedora Workstation 38/39.
I didn't bother testing or implementing cross-compiling for i386, if that is desired then it's a lot more work IMO. Another option would be building on native i386.
I did notice that "cyanrip" is already registered on snapcraft.io, if that isn't owned or acquired by this project, then another name should be chosen e.g. cyanrip-snap.
Note: The snap can still be built and installed outside of the store using
--devmode, if you elect not to use snapcraft.io. I mention that in the updated README.Remaining steps:
snapcraft.yaml