varstash: export the variable for storing stashed vars #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
That's interesting. Is there a use case that this supports? I'm hesitant because, once it's exported it's part of the interface and someone's will dog will die and they'll get fired if we ever need to take it out. @cxreg - any thoughts? |
Contributor
Author
I think it's more an issue of security, i.e. exporting makes it available for subcommands, which might possibly leak data. The reason for doing this was to handle it correctly in subshells (IIRC). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is really smart, but I've added it a while back for zsh-autoenv (Tarrasch/zsh-autoenv@c4e3889).