Skip to content

Vulnerability fix (powered by Mobb Autofixer) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cx-israel-ogunsakin wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Vulnerability fix (powered by Mobb Autofixer) #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b8c34b
mobb fix commit: 22a658e9-6032-4dc6-b2e3-bd74c2fcfb99
Sep 25, 2023
49e8dfa
mobb fix commit: 96b05587-b15d-497c-addc-b7ed3cefdc15
Sep 25, 2023
38b2868
mobb fix commit: 214bf700-2ada-4df9-84e6-83813ca102c3
Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/webapp/ForgotPassword.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ if(request.getParameter("secret")!=null)
{
Connection con=new DBConnect().connect(getServletContext().getRealPath("/WEB-INF/config.properties"));
ResultSet rs=null;
Statement stmt = con.createStatement();
rs=stmt.executeQuery("select * from users where username='"+request.getParameter("username").trim()+"' and secret='"+request.getParameter("secret")+"'");
PreparedStatement pstmt = con.prepareStatement("select * from users where username=? and secret=?");
pstmt.setString(1, request.getParameter("username").trim());
pstmt.setString(2, request.getParameter("secret"));
rs=pstmt.executeQuery();
if(rs != null && rs.next()){
out.print("Hello "+rs.getString("username")+", <b class='success'> Your Password is: "+rs.getString("password"));
}
Expand Down
6 changes: 4 additions & 2 deletions src/main/webapp/vulnerability/csrf/change-info.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,10 @@ if(session.getAttribute("isLoggedIn")!=null)
String id=session.getAttribute("userid").toString();
if(info!=null && !info.equals("") && id!=null)
{
Statement stmt = con.createStatement();
stmt.executeUpdate("Update users set about='"+info+"' where id="+id);
PreparedStatement pstmt = con.prepareStatement("Update users set about=? where id=?");
pstmt.setString(1, info);
pstmt.setString(2, id);
pstmt.executeUpdate();
out.print("<b class='fail'>info Changed</b>");
}

Expand Down
114 changes: 54 additions & 60 deletions src/main/webapp/vulnerability/forum.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
--%>

<%@page import="java.sql.Connection"%>
<%@page import="java.sql.Statement"%>
<%@page import="java.sql.PreparedStatement"%>
<%@page import="java.sql.SQLException"%>

<%@page import="java.sql.ResultSetMetaData"%>
Expand All @@ -18,65 +18,59 @@

<%@ include file="/header.jsp" %>
<%
Connection con=new DBConnect().connect(getServletContext().getRealPath("/WEB-INF/config.properties"));
if(session.getAttribute("isLoggedIn")!=null && session.getAttribute("isLoggedIn").equals("1"))
{
out.print("Hello "+session.getAttribute("user")+", Welcome to Our Forum !");
}
%>
<br/> <br/>
<h3>Create Post:</h3>
<form action="forum.jsp" method="POST">
Title : <input type="text" name="title" value="" size="50"/><br/>
Message: <br/><textarea name="content" rows="2" cols="50"></textarea>
<input type="hidden" name="user" value="<% if(session.getAttribute("user")!=null){out.print(session.getAttribute("user"));} else { out.print("Anonymous"); } %>" size="50"/><br/>
<input type="submit" value="Post" name="post"/>
</form>

try (Connection con = new DBConnect().connect(getServletContext().getRealPath("/WEB-INF/config.properties"))) {
if (session.getAttribute("isLoggedIn") != null && session.getAttribute("isLoggedIn").equals("1")) {
out.print("Hello " + session.getAttribute("user") + ", Welcome to Our Forum !");
}
}
%>
<br/> <br/>
<h3>Create Post:</h3>
<form action="forum.jsp" method="POST">
Title : <input type="text" name="title" value="" size="50"/><br/>
Message: <br/><textarea name="content" rows="2" cols="50"></textarea>
<input type="hidden" name="user" value="<% if(session.getAttribute(\"user\")!=null){out.print(session.getAttribute(\"user\"));} else { out.print(\"Anonymous\"); } %>" size="50"/><br/>
<input type="submit" value="Post" name="post"/>
</form>
<br/>
<%

if(request.getParameter("post")!=null)
{
String user=request.getParameter("user");
String content=request.getParameter("content");
String title=request.getParameter("title");
if(con!=null && !con.isClosed())
{
Statement stmt = con.createStatement();
//Posting Content
stmt.executeUpdate("INSERT into posts(content,title,user) values ('"+content+"','"+title+"','"+user+"')");
out.print("Successfully posted");
}
}

%>
<h3>List of Posts:</h3>
<%
if(con!=null && !con.isClosed())
{
Statement stmt = con.createStatement();
ResultSet rs =null;
rs=stmt.executeQuery("select * from posts");
out.println("<table border='1'>");
while (rs.next())
{
out.print("<tr>");
out.print("<td><a href='forumposts.jsp?postid="+rs.getString("postid")+"'>"+rs.getString("title")+"</a></td>");
out.print("<td> - Posted By ");
if(!rs.getString("user").equalsIgnoreCase("anonymous"))
{
out.print("<a href='UserDetails.jsp?username="+rs.getString("user")+"'>"+rs.getString("user")+"</a>");
}
else
{
out.print(rs.getString("user"));
}
out.println("</td></tr>");

if (request.getParameter("post") != null) {
String user = request.getParameter("user");
String content = request.getParameter("content");
String title = request.getParameter("title");
if (con != null && !con.isClosed()) {
String query = "INSERT into posts(content,title,user) values (?,?,?)";
try (PreparedStatement stmt = con.prepareStatement(query)) {
stmt.setString(1, content);
stmt.setString(2, title);
stmt.setString(3, user);
stmt.executeUpdate();
out.print("Successfully posted");
}
}
}
%>
<h3>List of Posts:</h3>
<%
if (con != null && !con.isClosed()) {
String query = "select * from posts";
try (PreparedStatement stmt = con.prepareStatement(query)) {
ResultSet rs = stmt.executeQuery();
out.println("<table border='1'>");
while (rs.next()) {
out.print("<tr>");");
out.print("<td><a href='forumposts.jsp?postid=" + rs.getString("postid") + "'>" + rs.getString("title") + "</a></td>");
out.print("<td> - Posted By ");
if (!rs.getString("user").equalsIgnoreCase("anonymous")) {
out.print("<a href='UserDetails.jsp?username=" + rs.getString("user") + "'>" + rs.getString("user") + "</a>");
} else {
out.print(rs.getString("user"));
}
out.println("</table>");
}
out.print("<br/> <a href='forumUsersList.jsp'>Forum Users list &gt;&gt;</a>");
%>
<%@ include file="/footer.jsp" %>
out.println("</td></tr>");
}
out.println("</table>");
}
}
out.print("<br/> <a href='forumUsersList.jsp'>Forum Users list &gt;&gt;</a>");
%>
<%@ include file="/footer.jsp" %>