fix: change the order of image source checking in HasMetadata#32
Open
dancing-janissary wants to merge 1 commit intocwsdigital:v1.xfrom
Open
fix: change the order of image source checking in HasMetadata#32dancing-janissary wants to merge 1 commit intocwsdigital:v1.xfrom
dancing-janissary wants to merge 1 commit intocwsdigital:v1.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functinally, If I had set a global OG Image from settings, All pages should display it for the SEO pruposes. However previous code was cousing trouble because of the HasMetadata:61 ( "elseif ($this->hasAnyBlockMedias())") control. In our system, it was taking an unreleated image in a block as og image instead of the global one in settings. This order change would fix this.