Add support for selecting sign in options dynamically from authentication tab#11
Open
Add support for selecting sign in options dynamically from authentication tab#11
Conversation
…tion tab Signed-off-by: Craig Perkins <craig5008@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TODO Add a video of the change.
Also plan to follow-up by addressing opensearch-project#2240 so that if only SAML/OIDC is configured (i.e. will auto-login), that a url param can be passed to show the login screen so an admin can choose to login via basic auth (even if dashboards is not configured to have basic auth as I sign in option, but backend supports it).
Category
Enhancement
Issues Resolved
opensearch-project#1573
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.