V3

[cwise89]

Implementation of useOnlineEffect. No tests yet to confirm on the correct path lol.

[fmaximus]

In case pollingObject.enabled === false, this would return an incorrect object

{
    enabled: false,
    url: 'https://ipv4.icanhazip.com/',
    timeout: 5000,
    interval: 5000,
}

Change to (needsPolling === true && typeof pollingConfig === 'object' && pollingConfig.enabled === undefined)

[fmaximus]

Better than using a callback would be use useState.

const [isOnline, setIsOnline] = useState(true);

const goOnline = () => {
    setIsOnline(true);
};

const goOffline = () => {
    setIsOnline(false);
};

...
setInterval(() => {
        ping(pingConfig).then(setIsOnline);
      }, interval);
...

return isOnline;

A user can then just use it like:

const isOnline = useOnlineEffect();

useEffect(() => {
  if (isOnline) { 
    console.debug("we're online");
  } else {
    console.warn("we're offline");
  }
}, [isOnline])

[fmaximus]

If callback is still wanted, you could add

if (callback) {
  useEffect(() => {
    callback(isOnline);
  }, [isOnline])
}

to have both options.

[fmaximus]

assign to intervalId

[fmaximus]

use if (intervalId) instead. It will only be set in this case.

[fmaximus]

Shouldn't getPollingConfigs have taken care to set enabled correctly.
Here you are overriding the choice of the user.
IMO enabled should suffice.

[fmaximus]

Could be simplified to .then(callback)

[alexanderadam]

Thank you so much for your work on this. 🙌
Is there any rough release date for v3? I saw someone asking this in an issue but the user closed it without a hint.