fix: use Tor-friendly endpoint in TestE2ECircuitBuild#17
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
example.com returns 403 to Tor exit nodes, causing consistent test failures. Switch to check.torproject.org and accept any valid HTTP response (including 301 redirect to HTTPS) as proof the circuit carried traffic end-to-end.
cvsouth
force-pushed
the
fix/e2e-tor-friendly-endpoint
branch
from
d2ed215 to
ba9cb87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
example.comreturns 403 to Tor exit nodes, causingTestE2ECircuitBuildto consistently fail in CIcheck.torproject.orgwhich is designed to be accessed via Tor and returns "Congratulations" when the connection is coming through TorTest plan
TestE2ECircuitBuildsucceeds with a 200 response fromcheck.torproject.org