feat(ui): add ability to change UI of template selection #54

AgatZan · 2024-08-15T21:38:13Z

chore: added typing
fix(wildcard): bugfix wildcard.parse. When finding a wildcard at lookup, it doesn't check if it function or string.
fix(util): probably bugfix. The default value for the inserttable pattern is nil. If gettemplates encounters nil, it will not process it.
feat(ui): Adding probability to change the default UI when selecting a template process. ( async or not)

Note(util): pattern = "" for type reason

AgatZan · 2024-08-15T21:54:48Z

lua/esqueleto/utils.lua

+-- ---@param dir string
+-- ---@param ignored_patterns string[]
+-- ---@return string[]
+-- local listignore = function(dir, ignored_patterns)


Iter alternative to listignored

I would add this version but I need to implement proper testing before relying on changing it. Will test it in my local version and decide on wheter we use this one for now.

lua/esqueleto/utils.lua

cvigilv · 2024-08-15T22:17:38Z

Awesome PR! Just a couple of questions:

Why did you revert the CI implementation?
Could you provide an example of a custom selector in the README? or even here, so I can test it works properly.
With the provided changes, I'm unable to make the plugin work. Could you provide your configuration to test it?

Thanks for the awesome work, I was aiming to implementing stuff like this in a near future whenever I was a little more free from work.

AgatZan · 2024-08-15T22:36:27Z

Awesome PR! Just a couple of questions:

Why did you revert the CI implementation?

Could you provide an example of a custom selector in the README? or even here, so I can test it works properly.

With the provided changes, I'm unable to make the plugin work. Could you provide your configuration to test it?

Thanks for the awesome work, I was aiming to implementing stuff like this in a near future whenever I was a little more free from work.

Because I was trying to figure it out during the work period, but since it fell with every commit, I decided that I still need to work on it.

In general, in order to start covering the repository with tests

I added selector to esqueleto/selector/builtin

function(templatenames)
	-- Sync call ui.select
	-- See: https://github.com/mfussenegger/nvim-dap/blob/66d33b7585b42b7eac20559f1551524287ded353/lua/dap/ui.lua#L55
	local co = coroutine.running()
	local choicer = function(choice)
		if not choice then
			vim.notify(
				"[esqueleto] No template selected, leaving buffer empty",
				vim.log.levels.INFO
			)
		end
		coroutine.resume(co, choice)
	end
	-- I don't know reason to use that
	-- choicer = vim.schedule_wrap(choicer)
	vim.ui.select(templatenames, { prompt = "Select skeleton to use:" }, choicer)
	return coroutine.yield()
end

I took the very idea of implementing this from here

I got a little carried away with my study of the codebase through adding types and missed this point, so most likely there will be bugs. I apologize m(_ _)m

nevertheless, after checking, I have it open on simple files

my config

cvigilv · 2024-08-15T23:41:29Z

Perfect, I will do some work now dedicated to CI/CD so I can release a new version.
I noticed it, just thought you may have implemented something custom on your config (like a Telescope selector or something like that). I'll give it a go to implement new selectors locally, but for now this works as intended.

Regarding point 3. I made a mistake on my side, that's why it didn't work. It works as intended so, don't worry.

Overall the PR is great, just some stylistic differences that can be revised. Will merge on the weekend after going through everything in the case I need some changes. Thanks!

cvigilv · 2024-09-25T19:35:29Z

Haven't merged this since its not working on my local version. Will try to see how I can incorporate this in the coming version. For now I will let it as is and get back to it whenever I finish the other things I'm developing for the plugin.

cvigilv · 2024-10-02T15:30:35Z

Could you provide a screen recording of this working? havent been able to make it work in my local version

AgatZan · 2024-10-02T15:50:10Z

Could you provide a screen recording of this working? havent been able to make it work in my local version

plugin/esqueleto.lua

return {
	"AgatZan/esqueleto.nvim",
	---@type Esqulato.config
	opts = {
		patterns = { "python" },
	},
}

It`s test builtin selector

AgatZan · 2024-10-02T15:58:56Z

Also work with esqueleto.selectors.telescope but if you use lazy this may be obvious, but at opts selector=require("esqueleto.selectors.telescope") throw error, so configurate at config = function()

cvigilv · 2024-10-02T16:11:09Z

It indeeds works, dont know why it would not work on my computer. What version of Neovim are you using? I generally work in nightly for plugin dev.

AgatZan · 2024-10-02T18:51:13Z

NVIM v0.10.1
Build type: Release
LuaJIT 2.1.1713484068

AgatZan · 2024-10-02T19:04:05Z

lua/esqueleto/utils.lua

+
+  -- wrap to coroutine to have possibility to async function
+  ---@see esqueleto.selectors.builtin
+  coroutine.wrap(function()


I think only one breaking chang at that place, if it work correct, then it must work correct either errors exists at another functions

Using this PR, I get the following error:

Error detected while processing BufNewFile Autocommands for "*": Error executing lua callback: .../latest/nvim-macos-arm64/share/nvim/runtime/filetype.lua:36: BufNewFile Autocommands for "*"..FileType Autocommands for "*"..FileType Autocommands for "*"..FileType Autocomman ds for "*"..FileType Autocommands for "*"..FileType Autocommands for "*"..FileType Autocommands for "*"..FileType Autocommands for "*"..FileType Autocommands for "*"..FileType Autocommands for "*": Vim(append ):Error executing lua callback: ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:182: ...queleto_dev/lazy/plenary.nvim/lua/plenary/popup/init.lua:122: Vim:E218: Autocommand nesting too deep stack traceback: [builtin#36]: at 0x01008f59f0 ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:182: in function 'selecttemplate' ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:208: in function 'inserttemplate' ...carlosvigil/git/esqueleto.nvim/lua/esqueleto/autocmd.lua:19: in function <...carlosvigil/git/esqueleto.nvim/lua/esqueleto/autocmd.lua:15> [builtin#36]: at 0x01008f59f0 ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:182: in function 'selecttemplate' ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:208: in function 'inserttemplate' ...carlosvigil/git/esqueleto.nvim/lua/esqueleto/autocmd.lua:19: in function <...carlosvigil/git/esqueleto.nvim/lua/esqueleto/autocmd.lua:15> [builtin#36]: at 0x01008f59f0 ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:182: in function 'selecttemplate' ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:208: in function 'inserttemplate' ... [builtin#36]: at 0x01008f59f0 ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:182: in function 'selecttemplate' ...s/carlosvigil/git/esqueleto.nvim/lua/esqueleto/utils.lua:208: in function 'inserttemplate' ...carlosvigil/git/esqueleto.nvim/lua/esqueleto/autocmd.lua:19: in function <...carlosvigil/git/esqueleto.nvim/lua/esqueleto/autocmd.lua:15> [C]: in function 'nvim_cmd' .../latest/nvim-macos-arm64/share/nvim/runtime/filetype.lua:36: in function <.../latest/nvim-macos-arm64/share/nvim/runtime/filetype.lua:35> [C]: in function 'pcall' vim/shared.lua: in function <vim/shared.lua:0> [C]: in function '_with' .../latest/nvim-macos-arm64/share/nvim/runtime/filetype.lua:35: in function <.../latest/nvim-macos-arm64/share/nvim/runtime/filetype.lua:10> stack traceback: [C]: in function '_with' .../latest/nvim-macos-arm64/share/nvim/runtime/filetype.lua:35: in function <.../latest/nvim-macos-arm64/share/nvim/runtime/filetype.lua:10>

AgatZan · 2024-10-02T19:59:53Z

I test it with minimal-minimal setup.

DEV_DIR = "~/nvim-plug/esqueleto.nvim"
vim.opt.rtp:prepend(DEV_DIR)
require("esqueleto").setup({patterns = {"python"}}

And only 1 that i found, that i should decorate if selectors/builtin.lua choicer

cvigilv · 2024-10-02T20:14:12Z

I didnt get what you refer to. I prefer you test things with the lazy-based minimal example since the vast majority of user use lazy for pkg management.

AgatZan · 2024-10-02T20:43:23Z

I think it doesn't really matter, but i test and it works

cvigilv · 2024-10-02T21:36:03Z

Are you cleaning the plugins whenever you launch neovim? I'm using CLI neovim and use the NVIM_APPIMAGE environmental variable to ensure no other plugins are being loaded. I don't know if there is an equivalent in Neovide.

AgatZan · 2024-10-02T22:08:32Z

I removed all cached plugins and used a minimal setup and use cli nvim. I had no problems.

cvigilv · 2024-10-03T14:05:01Z

Lost for words here. Will have to deep dive into telescope to see what is the problem. Thanks for your help

AgatZan added 5 commits August 13, 2024 03:38

Add CI

430c3bd

fix(type): Introduce type

cb9acc0

fix: type error at wildcard parse

1b4e265

Note(util): pattern = "" for type reason

feat(template): select from suggested templatenames

a7a0f57

revert: Add CI

d071e49

AgatZan commented Aug 15, 2024

View reviewed changes

lua/esqueleto/utils.lua Show resolved Hide resolved

cvigilv changed the title ~~Feat: Adding the ability to change the UI of the templatename selection~~ feat(ui): add ability to change UI of template selection Aug 16, 2024

cvigilv added 2 commits August 15, 2024 20:38

refactor: use Iter-version

33d5526

refactor(ui): give templates name and paths to selectors

44da5da

AgatZan added 2 commits October 2, 2024 18:07

feat(default.finder): telescope

054c87a

fix(telescope): misspell generic_sorter

3d808ad

AgatZan mentioned this pull request Oct 2, 2024

Telescope ui choicer #58

Open

AgatZan commented Oct 2, 2024

View reviewed changes

fix(pickers): builtin wrap into schedule

e102cdf

chore: remove debug print

1994c1f

feat(ui): add ability to change UI of template selection #54

Are you sure you want to change the base?

feat(ui): add ability to change UI of template selection #54

Uh oh!

Conversation

AgatZan commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AgatZan Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

cvigilv Aug 15, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cvigilv commented Aug 15, 2024

Uh oh!

AgatZan commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvigilv commented Aug 15, 2024

Uh oh!

cvigilv commented Sep 25, 2024

Uh oh!

cvigilv commented Oct 2, 2024

Uh oh!

AgatZan commented Oct 2, 2024

Uh oh!

AgatZan commented Oct 2, 2024

Uh oh!

cvigilv commented Oct 2, 2024

Uh oh!

AgatZan commented Oct 2, 2024

Uh oh!

AgatZan Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

cvigilv Oct 2, 2024

Choose a reason for hiding this comment

Uh oh!

AgatZan commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvigilv commented Oct 2, 2024

Uh oh!

AgatZan commented Oct 2, 2024

Uh oh!

cvigilv commented Oct 2, 2024

Uh oh!

AgatZan commented Oct 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvigilv commented Oct 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AgatZan commented Aug 15, 2024 •

edited

Loading

AgatZan commented Aug 15, 2024 •

edited

Loading

AgatZan commented Oct 2, 2024 •

edited

Loading

AgatZan commented Oct 2, 2024 •

edited

Loading