Skip to content

fix: prevent crash when result of SendMessage is 0 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shunf4 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: prevent crash when result of SendMessage is 0 #63

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c09d46
fix: prevent crash when result of SendMessage is 0
shunf4 Apr 15, 2022
5411ae0
remove null checks for psd and usersid before freeing
shunf4 Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion winpgntc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,18 @@ agent_query(void *buf)
UnmapViewOfFile(p);
CloseHandle(filemap);
LocalFree(psd);
psd = NULL;
free(usersid);

usersid = NULL;
if (id > 0)
return;
}

/* LocalFree and free are fine with NULL, so null checks aren't
* necessary. */
LocalFree(psd);
free(usersid);

}

static const char reply_error[5] = { 0, 0, 0, 1, SSH_AGENT_FAILURE };
Expand Down