Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97de18109b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const shouldAutoExpand = Boolean(normalizeSearchTerm(currentSearchTerm)); | ||
| if (shouldAutoExpand) { | ||
| setPageDetailsExpanded(pageItem, page, true, currentSearchTerm); |
There was a problem hiding this comment.
Reapply search filter before auto-expanding page details
displayFilteredPages now auto-expands every rendered row whenever currentSearchTerm is non-empty. Flows like deleting a page (deletePageHighlights), importing, or refreshPagesList call loadAllHighlightedPages(), which repopulates filteredPages from all pages without rerunning filterPages; with an active query this makes non-matching pages appear and all of them expand unexpectedly. This regression is user-visible after any data refresh during search, so expansion should be gated to actual matches or the filter reapplied after reload.
Useful? React with 👍 / 👎.
Summary
Testing
npm testnpx playwright test e2e-tests/pages-list.spec.js -g "search expands filtered page details, highlights matching text, and refresh clears the search input"