Skip to content

Improve pages list search UX#93

Merged
cuspymd merged 1 commit intomainfrom
feat/pages-list-search-ux
Apr 6, 2026
Merged

Improve pages list search UX#93
cuspymd merged 1 commit intomainfrom
feat/pages-list-search-ux

Conversation

@cuspymd
Copy link
Copy Markdown
Owner

@cuspymd cuspymd commented Apr 5, 2026

Summary

  • improve the Pages List search experience by auto-expanding matching page details
  • highlight search term matches in page titles, URLs, and highlight text with a theme-aligned purple accent
  • reset the search input when the refresh button reloads the list
  • add a Playwright E2E test that covers search expansion, match highlighting, and refresh reset behavior

Testing

  • npm test
  • npx playwright test e2e-tests/pages-list.spec.js -g "search expands filtered page details, highlights matching text, and refresh clears the search input"

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 97de18109b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +343 to +345
const shouldAutoExpand = Boolean(normalizeSearchTerm(currentSearchTerm));
if (shouldAutoExpand) {
setPageDetailsExpanded(pageItem, page, true, currentSearchTerm);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reapply search filter before auto-expanding page details

displayFilteredPages now auto-expands every rendered row whenever currentSearchTerm is non-empty. Flows like deleting a page (deletePageHighlights), importing, or refreshPagesList call loadAllHighlightedPages(), which repopulates filteredPages from all pages without rerunning filterPages; with an active query this makes non-matching pages appear and all of them expand unexpectedly. This regression is user-visible after any data refresh during search, so expansion should be gated to actual matches or the filter reapplied after reload.

Useful? React with 👍 / 👎.

@cuspymd cuspymd merged commit fbaad83 into main Apr 6, 2026
2 checks passed
@cuspymd cuspymd deleted the feat/pages-list-search-ux branch April 6, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant