Skip to content

fix: strip selection URL fragment to prevent highlights disappearing in Firefox #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cuspymd merged 2 commits into from
Apr 3, 2026
Merged

fix: strip selection URL fragment to prevent highlights disappearing in Firefox #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd94ffc
fix: strip selection fragment from URL in Firefox to save highlights …
cuspymd Apr 3, 2026
ea47e28
fix: merge with main and extend selection URL normalization to handle…
cuspymd Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions content-scripts/content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
let highlights = [];
let currentUrl = window.location.href;
let currentUrl = window.location.href.replace(/#selection-[\d.]+-[\d.]+$/, '');

let currentColors = [];
const contentCore = window.TextHighlighterCore;
Expand Down Expand Up @@ -68,15 +68,16 @@ function injectNavigationBridge() {
}

function handleUrlChange(nextUrl, trigger = 'unknown') {
if (!nextUrl || nextUrl === currentUrl) return;
const normalizedUrl = nextUrl ? nextUrl.replace(/#selection-[\d.]+-[\d.]+$/, '') : nextUrl;
if (!normalizedUrl || normalizedUrl === currentUrl) return;

debugLog('Detected URL change:', {
trigger,
previousUrl: currentUrl,
nextUrl,
nextUrl: normalizedUrl,
});

currentUrl = nextUrl;
currentUrl = normalizedUrl;
highlights = [];

if (typeof hideHighlightControls === 'function') {
Expand Down
Loading