Maplinefix #10
Open
Maplinefix #10
+2,083
−966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on Xcode 9... Must add new testing framework
eselkin
suggested changes
Oct 19, 2017
eselkin
left a comment
eselkin
left a comment
There was a problem hiding this comment.
Looks good. I see no performance improvements. Not sure why you're adding Expo though... We worked to remove Expo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performed an upgrade to RN as outlined here. Also added the dependency for Expo. I'm exploring how to use it with an "ejected" version of react native as expo may help us test better on non-virtual devices.
Also, upgrading appears to improve performance on loading street lines.
If anyone gets a min if they could download and run and verify if this upgrade works fine for then I'd appreciate it.
Justin