Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbf1ed5e43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| function buildTopicTagUrl(tagText) { | ||
| const text = String(tagText || '').trim(); | ||
| if (!text) return '/news/topic/'; | ||
| return `/news/topic/?tag=${encodeURIComponent(text)}`; |
There was a problem hiding this comment.
Generate topic links with the supported query parameter
buildTopicTagUrl now builds URLs as /news/topic/?tag=..., but the topic page loader only reads a path slug or the topic query key (news/topic/index.html, getTopicFromUrl, lines 543-548). In practice, clicking any of these newly added links drops the selected tag and loads the generic Topic state, so users get empty/irrelevant results instead of filtered content. Please emit topic (or the slug path format) here so the new links actually drive topic filtering.
Useful? React with 👍 / 👎.
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task