Skip to content

Codex-generated pull request#1

Open
cuitengweii wants to merge 22 commits intomainfrom
codex/fix-index-page-navigation-links-in-news
Open

Codex-generated pull request#1
cuitengweii wants to merge 22 commits intomainfrom
codex/fix-index-page-navigation-links-in-news

Conversation

@cuitengweii
Copy link
Copy Markdown
Owner

Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.


Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dbf1ed5e43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

function buildTopicTagUrl(tagText) {
const text = String(tagText || '').trim();
if (!text) return '/news/topic/';
return `/news/topic/?tag=${encodeURIComponent(text)}`;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Generate topic links with the supported query parameter

buildTopicTagUrl now builds URLs as /news/topic/?tag=..., but the topic page loader only reads a path slug or the topic query key (news/topic/index.html, getTopicFromUrl, lines 543-548). In practice, clicking any of these newly added links drops the selected tag and loads the generic Topic state, so users get empty/irrelevant results instead of filtered content. Please emit topic (or the slug path format) here so the new links actually drive topic filtering.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant