Fixes #31 and #37 where icons were not properly aligned in images#40
Open
lesserj wants to merge 1 commit intocugos:mainfrom
Open
Fixes #31 and #37 where icons were not properly aligned in images#40lesserj wants to merge 1 commit intocugos:mainfrom
lesserj wants to merge 1 commit intocugos:mainfrom
Conversation
…images The 2x version of the button sprite had different proportions from the 1x version of the sprite, so the background-size property was incorrect and icons were not correctly positioned on some screens. Updating to the latest Leaflet.Draw didn't fix the issue and in fact made it worse, so I just modified the sprites to match so the only difference is the 2x scale.
|
would love to see this merged soon, so its fixed! |
|
The CSS fix alone fixes it perfectly for me (tried it with dev tools) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2x version of the button sprite had different proportions from the 1x version of the sprite, so the background-size property was incorrect and icons were not correctly positioned on some screens. Updating to the latest Leaflet.Draw didn't fix the issue and in fact made it worse, so I just modified the sprites to match so the only difference is the 2x scale.